Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #311 Add support for markdown constructs not in the core commonmark spec #423

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

pri22296
Copy link
Member

@pri22296 pri22296 commented Aug 23, 2017

Description

Now contents enclosed within a <!-- markdown+ --> and <!-- endmarkdown+ --> will be handled by pandoc instead of recommonmark which enables us to support non commonmark features such as tables

Related Issue

Fixes #311

Motivation and Context

This is essential to support the full github flavoured markdown instead of just the commonmark spec as currenty recommonmark library does not provide an api to add extensions.

How Has This Been Tested?

Deployment: https://yaydocmd.herokuapp.com

Screenshots (if appropriate):

Types of changes

  • Bug fix
  • New feature

Checklist:

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only one commit per issue.

@pri22296
Copy link
Member Author

@imujjwal96 @Sch00lb0y Please review. Also please suggest a better name for markdown+ if possible.

@pri22296 pri22296 requested review from imujjwal96 and poonai August 25, 2017 10:41
@imujjwal96
Copy link
Contributor

Any sample docs?

Copy link
Contributor

@imujjwal96 imujjwal96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants