-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor logic analyzer #167
base: develop
Are you sure you want to change the base?
Conversation
I was thinking about having a separate |
In general, I don't think it's necessary for small projects with few committers to have parallel On the other hand, merging known broken code (which this is) into |
8d93290
to
466d79a
Compare
eef9251
to
33448ed
Compare
33448ed
to
f20242b
Compare
Going to merge this soon (into the new and probably temporary 'develop' branch). Some notes on this change:
|
This is the first part of the major refactorization I'm currently working on. It refactors the logic analyzer instrument, as well as the underlying hardware drivers it depends on, including:
This pull request breaks any instrument which depend on an interrupt service routine from any of the above drivers. This is because I'm refactoring the interrupts to be more modular by using callbacks. The broken instruments will be fixed as part of the ongoing refactorization.
The new low-level hardware drivers currently reside in src/registers_ng, to be renamed to src/registers once the refactorization is complete. These drivers are designed to be self-contained, i.e. they have no dependencies on any resources other than themselves. This design aims to solve the current spaghetti-ness of the firmware code, where every module depends on several other modules, often in a transitive or circular manner.
Depends on #165 and #166.