chore: add ktlint in Travis #640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
force-pushed
the
ktlint
branch
3 times, most recently
from
c06f48a to
478e503
Compare
|
@iamareebjamal Please review |
|
Don't disable the wildcard imports check, we'll fix it in upcoming commits |
|
@iamareebjamal updated. Please revie |
app/build.gradle
Outdated
| description = "Check Kotlin code style." | ||
| classpath = configurations.ktlint | ||
| main = "com.github.shyiko.ktlint.Main" | ||
| args "src/**/*.kt" |
app/build.gradle
Outdated
| description = "Fix Kotlin code style deviations." | ||
| main = "com.github.shyiko.ktlint.Main" | ||
| classpath = configurations.ktlint | ||
| args "-F", "src/**/*.kt" |
|
Updated |
iamareebjamal
requested changes
Oct 15, 2018
app/build.gradle
Outdated
| @@ -137,12 +137,12 @@ task ktlint(type: JavaExec, group: "verification") { | |||
| description = "Check Kotlin code style." | |||
| classpath = configurations.ktlint | |||
| main = "com.github.shyiko.ktlint.Main" | |||
| args "src/**/*.kt" | |||
| args "--androidsrc/**/*.kt" | |||
There was a problem hiding this comment.
There should be a space after android
Try running this locally
There was a problem hiding this comment.
Updated. The task keeps running, it never completes
|
Build is failing |
|
@iamareebjamal yes it will fail. As far as I know only way of making the build pass is adding those comments for wildcard imports. This is a bug in the library that has still not been solved Do you know any other alternative ? |
|
OK, will see |
|
Superseded by #769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639