Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add unit testing for utils and error utils #2307

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

liveHarshit
Copy link
Member

Fixes #2305

Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for robo electric test. Why do you want it to take 1000 years when it can take 0.13 seconds?

@liveHarshit
Copy link
Member Author

No need for robo electric test. Why do you want it to take 1000 years when it can take 0.13 seconds?

I used it from the orga app, to create HTTP exception Will update 👍

@iamareebjamal
Copy link
Member

HTTPException is Retrofit error. What does it have to do with Android?

@liveHarshit
Copy link
Member Author

HTTPException is Retrofit error. What does it have to do with Android?

So I need to add different exceptions manually?

@iamareebjamal
Copy link
Member

I don't know what you mean

@liveHarshit
Copy link
Member Author

I don't know what you mean

We need to pass an HTTP exception to test the utils.

@iamareebjamal
Copy link
Member

So, why do you need Android tests. Why can't you do it in Java?

@liveHarshit
Copy link
Member Author

So, why do you need Android tests. Why can't you do it in Java?

That why I was asking, I need to add exceptions manually.

@iamareebjamal
Copy link
Member

I don't understand till now. What makes it automatic in Android? Why will you have to do it manually in Java?

I have already asked this 3 times

HTTPException is Retrofit error. What does it have to do with Android?

So, why do you need Android tests. Why can't you do it in Java?

@aggarwalpulkit596
Copy link
Contributor

@liveHarshit any updates on this

@iamareebjamal
Copy link
Member

@aggarwalpulkit596 Please continue on this if you want

@aggarwalpulkit596
Copy link
Contributor

Cool I'll start with this

@aggarwalpulkit596
Copy link
Contributor

@liveHarshit what's missing in this PR?

@iamareebjamal
Copy link
Member

These are roboelectric tests, should be junit tests

@aggarwalpulkit596
Copy link
Contributor

Yeah makes sense

@aggarwalpulkit596
Copy link
Contributor

aggarwalpulkit596 commented Oct 23, 2019

@iamareebjamal
https://github.com/jasminb/jsonapi-converter/blob/791f020496fe50aa41b3e72cd058756eea6e8b28/src/test/java/com/github/jasminb/jsonapi/retrofit/RetrofitTest.java#L104
Something like this has to be implemented? Right?

GitHub
JSONAPI-Converter is a Java/Android library that provides support for working with JSONAPI spec - jasminb/jsonapi-converter

@iamareebjamal
Copy link
Member

No, it has nothing to do with JSON API but if it can be done this way, then yes

@aggarwalpulkit596
Copy link
Contributor

It's just way of implementing stuff with pure java no Android code required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit testing for utils and error utils
3 participants