-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add unit testing for utils and error utils #2307
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for robo electric test. Why do you want it to take 1000 years when it can take 0.13 seconds?
I used it from the orga app, to create HTTP exception Will update 👍 |
HTTPException is Retrofit error. What does it have to do with Android? |
So I need to add different exceptions manually? |
I don't know what you mean |
We need to pass an HTTP exception to test the utils. |
So, why do you need Android tests. Why can't you do it in Java? |
That why I was asking, I need to add exceptions manually. |
I don't understand till now. What makes it automatic in Android? Why will you have to do it manually in Java? I have already asked this 3 times
|
@liveHarshit any updates on this |
@aggarwalpulkit596 Please continue on this if you want |
Cool I'll start with this |
@liveHarshit what's missing in this PR? |
These are roboelectric tests, should be junit tests |
Yeah makes sense |
@iamareebjamal
|
No, it has nothing to do with JSON API but if it can be done this way, then yes |
It's just way of implementing stuff with pure java no Android code required |
Fixes #2305