Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power-management lxqt config #110

Closed
wants to merge 9 commits into from
Closed

Power-management lxqt config #110

wants to merge 9 commits into from

Conversation

meets2tarun
Copy link
Member

Short description

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
    This PR will take care of switching of screen saver and power management in LXQt version of meilix.
    Configuration needed in the LXQt version #88

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

@tabesin
Copy link
Member

tabesin commented Jul 27, 2017

Pls rebase

@tabesin
Copy link
Member

tabesin commented Jul 31, 2017

Please rebase, rebuild metapackage, so we can merge.

@meets2tarun meets2tarun requested a review from tabesin August 2, 2017 18:06
Copy link
Member

@tabesin tabesin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent you a PR to your Fork's screen-dimming branch...

@@ -112,6 +112,11 @@ apt-get -q -y -o Dpkg::Options::="--force-overwrite" --purge install chromium-br
#rm -rf /etc/chromium-browser
mv /etc/chromium-browser_ /etc/chromium-browser

#set the screen-saver and power-management off
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be also in
/home/username/.profile
?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these changes will go in .profile not here.

@@ -112,6 +112,11 @@ apt-get -q -y -o Dpkg::Options::="--force-overwrite" --purge install chromium-br
#rm -rf /etc/chromium-browser
mv /etc/chromium-browser_ /etc/chromium-browser

#set the screen-saver and power-management off
xset -dpms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess these changes take effect on the build time system, but are they kept for the generated runtime as well? Please check.

meets2tarun and others added 2 commits August 4, 2017 21:10
* Fixes issue #88 turn off screensaver

* Fixes the conflicting package for Firefox present in meilix-default-settings metapackage (#134)

* deleted the blacklist.d/firefox file because it causes conflicting and it doesn't let firefox to start.

* updated travis

* Fixes issue #135 Disabling screensaver

* Fixes #135

* Let's better add the rest of .profile

* and rm the dublicate

* sync the two profile files

* added endline
@meets2tarun
Copy link
Member Author

this will solve this issue #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants