adding response of packages checkbox #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav1698
reviewed
Mar 26, 2019
| @@ -144,6 +144,7 @@ def index(): | |||
| features[name] = value | |||
| recipe = json.dumps(variables, ensure_ascii=False) # Dumping the generator-packages into a JSON array | |||
| feature = json.dumps(features, ensure_ascii=False) # Dumping the chosen features into a JSON objects | |||
| INSTALL = request.form.getlist('INSTALL') | |||
There was a problem hiding this comment.
@rpotter12 this is already implemented here:
Line 141 in 09fcf76
No need of the pr, as the response on checkboxes is already implemented
Try triggering a build using your deployment
| <span>Chromium</span> | ||
| </label> | ||
| </div> | ||
| <div class="input__less"> | ||
| <label class="checkbox"> | ||
| <input type="checkbox" value="firefox" name="INSTALL_firefox"> | ||
| <input type="checkbox" value="firefox" name="INSTALL"> |
There was a problem hiding this comment.
@rpotter12 this is a redunant change will not have any affect on the working of the app, I think different names provide more clarity to the packages being installed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.adding response for package checkbox to check which packages need to be install.
Fixes #435