Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyright issue solved which is overlapping #743

Merged
merged 4 commits into from
Jul 7, 2020

Conversation

Raunaksingh100
Copy link
Member

@Raunaksingh100 Raunaksingh100 commented Jul 4, 2020

preview link After the code changes - https://trusting-hawking-64b2c4.netlify.app/
issue fixed - #742 , #737

@Chaitanyassr @Dishebh
just added the margin bottom to the coypright footer ....

In this i solved two issues

  1. I Solved issue Copyright issue not solved yet!! footer problem #742 (copyright issue which is overlaping to bottom)
  2. I Solved issue Issue with the Sponsorship info Button  #737 (added media query to make sponsorship button responsive and avoid overlapping)

Screenshot before--
footer issue

screenshot after ---
footer issue solved

@Dishebh
Copy link
Member

Dishebh commented Jul 6, 2020

Preview link should show the improvements done on the website. The one mentioned in the PR description only shows the original website. Kindly update it with a link that reflects the changes done. One way of doing that would be to host your site using any web-hosting services like surge or netlify.

@Raunaksingh100
Copy link
Member Author

@Dishebh here the preiview link after code changes plz have a look on this

https://trusting-hawking-64b2c4.netlify.app/

Copy link
Member

@Dishebh Dishebh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@fcartegnie fcartegnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that code does duplicate rules, does nothing.

@Raunaksingh100
Copy link
Member Author

Raunaksingh100 commented Jul 18, 2020

@fcartegnie this code works you can also check in the offical website of fossaisa.org
and this pr i solved two issues first read by PR description ..........

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants