-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dynamic language and URL input fields #133
Adding dynamic language and URL input fields #133
Conversation
bf35e4b
to
81b93e8
Compare
68b1813
to
05bde03
Compare
Force pushing to bring back the changes to my messed up PR. |
Reviewer's Guide by SourceryThis pull request introduces dynamic input fields for adding languages and their corresponding YouTube URLs. It also includes a button that allows the admin user to add more language and URL pairs dynamically. The changes affect several components, including the AudioTranslationDropdown, ChatContent, MediaSource, and various views and store files. The main focus is on enabling dynamic language selection and handling YouTube URLs for audio translations. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @untari - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Ok, so we need to test this in a larger team with more people and this will only be possible when deployed to production. For now I could see that key features work. Good job! Thank you! |
This pull request introduces dynamic input fields for adding languages and their corresponding YouTube URLsas part of the task in this issues: (#113) It also includes a button that allows the admin user to add more language and URL pairs dynamically.
Showcase for audio translation dropdown menu:
The current setup will display only the language titles in the dropdown menu. However, when a language is selected, it will only emit the selected language's title, not the associated URL yet.
Summary by Sourcery
This pull request introduces dynamic input fields for adding languages and their corresponding YouTube URLs, along with a button for admin users to add more language and URL pairs dynamically. It also enhances the audio translation dropdown and media source components to handle language changes and dynamically update the YouTube video being played.
AudioTranslationDropdown
component to handle language changes and emit the selected language's YouTube ID.MediaSource
component to support dynamic language audio URLs and iframes for language-specific YouTube videos.rooms/item.vue
view to initialize languages dynamically and handle language changes.stage.vue
view in the admin interface to use YouTube video IDs instead of URLs for language entries.