Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #833

Merged
merged 9 commits into from
Feb 4, 2017
Merged

Various fixes #833

merged 9 commits into from
Feb 4, 2017

Conversation

niol
Copy link
Collaborator

@niol niol commented Dec 28, 2016

Various fixes detailed in the individual patches.

@lumiru
Copy link
Contributor

lumiru commented Dec 31, 2016

I think you at least need to add a IfModule on .htaccess (or modify install/upgrade documentation about Apache configuration) :

<IfModule mod_authz_core.c>
                        Require all granted
</IfModule>

@@ -49,3 +49,4 @@ lang_login_username=Identifiant
lang_login_password=Mot de passe
lang_no_title=Sans titre
lang_error=Une erreur est survenue
lang_streamerror=Erreur lors du chargement de la liste, essayer à nouveau?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a space before ?

@niol
Copy link
Collaborator Author

niol commented Jan 2, 2017

Regarding the <IfModule mod_authz_core.c>, as a selfoss user, I'd prefer a 500 Internal Server Error rather than my password hash being exposed and the rule not being applied silently.

@lumiru
Copy link
Contributor

lumiru commented Jan 3, 2017

You make a point.

So you should add something about the minimum version in installation instructions (or as known issue).

'ALTER TABLE items ADD shared BOOLEAN;',
'INSERT INTO version (version) VALUES (9);'
));
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this double closing bracket?

@SSilence
Copy link
Member

SSilence commented Feb 3, 2017

@niol may you send me a short email ([email protected]) that I have your email address?

@SSilence SSilence merged commit f323b7d into fossar:master Feb 4, 2017
@niol niol deleted the ppr/fixqueue branch February 6, 2017 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants