Optionaly proxify images src with atmos/camo

[luxifer]

I used selfoss every day with a Let's Encrypt certificate but the connection is not fully encrypted when some feeds have images that does not come from https. To address this situation I used https://github.com/atmos/camo (an http proxy to serve images through SSL). It's optional so if the configuration for host and key are empty, nothing is done.

[niol]

This looks very useful, thanks.

But is seems to be a lot of code for something that could be implemented using a htmLawed hook and some f3 standard functions.

[luxifer]

I'll check this out and rewrite my PR to be shorter and leaner. This was a
proof of concept. Thanks for the insight.

Florent Viel
Le 23 juin 2016 11:05 AM, "niol" [email protected] a écrit :

This looks very useful, thanks.

But is seems to be a lot of code for something that could be implemented
using a htmLawed hook and some f3 standard functions.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#781 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAZlBtp_EDT_t36l4a7DGjTVK7dWGlVeks5qOkxqgaJpZM4I7uCm
.

[jtojnar]

I like it the way it is implemented here, separation of concerns-wise.

[jtojnar]

Hi @luxifer. Previously, it was not clear if selfoss was licensed under GPL 3 only, or also any later version. Could you clarify whether you are fine with licensing your contribution under GPL-3-or-later?

Thanks again and sorry for the confusion.

[luxifer]

I'm fine with GPL-3 licensing

[jtojnar]

@luxifer Unfortunately, the fact that GPL 3 is ambiguous (as described in https://gnu.org/licenses/identify-licenses-clearly.html) is the whole reason for the uncertainty. Could you please clarify whether you are okay with GPL-3-or-later rather than GPL-3-only specifically?

[luxifer]

Sorry for the confusion but I'm fine with any licensing ;)