Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to collapse/expand filter list #760

Merged
merged 2 commits into from
May 2, 2016
Merged

Allow to collapse/expand filter list #760

merged 2 commits into from
May 2, 2016

Conversation

gerundt
Copy link
Contributor

@gerundt gerundt commented Apr 27, 2016

This patch allow to collapse/expand the filter list like the tags and the sources.

@jtojnar
Copy link
Member

jtojnar commented Apr 27, 2016

Looks nice but the utilised area shrinks as the filters are collapsed making the whole thing rather useless.

expand

@gerundt
Copy link
Contributor Author

gerundt commented Apr 28, 2016

Mhh, I tested it with Firefox, IE 11 and Android Chrome and have no problems. Which browser use you?

@jtojnar
Copy link
Member

jtojnar commented Apr 28, 2016

I tried Firefox and Midori, both exhibit the same behaviour:

https://gfycat.com/ThriftySomberIrishwaterspaniel

@gerundt
Copy link
Contributor Author

gerundt commented Apr 28, 2016

Ok, I see the problem now too. I will look to find a solution. Thank you for your hint!

@gerundt
Copy link
Contributor Author

gerundt commented Apr 28, 2016

I hope 0873875 fix the problem. Can you try it? :)

@gerundt gerundt closed this Apr 28, 2016
@gerundt gerundt reopened this Apr 28, 2016
@jtojnar
Copy link
Member

jtojnar commented Apr 28, 2016

This is more usable but the transition looks horrible. How about moving the filters inside the container with scrollbar?

https://gfycat.com/HomelyWelllitHorsechestnutleafminer

@gerundt
Copy link
Contributor Author

gerundt commented Apr 28, 2016

Yes, moving the filters inside the container with the scrollbar could be an option! But I am not sure, if I have enough JavaScript and CSS knowledge for this. :-(

@SSilence SSilence merged commit f66195c into fossar:master May 2, 2016
@jtojnar
Copy link
Member

jtojnar commented Sep 27, 2020

Hi @gerundt. Previously, it was not clear if selfoss was licensed under GPL 3 only, or also any later version. Could you clarify whether you are fine with licensing your contributions here and in other PRs under GPL-3-or-later?

Thanks again and sorry for the confusion.

@gerundt
Copy link
Contributor Author

gerundt commented Sep 27, 2020

Hi, i am fine with GPL 3 or later for all my commits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants