Adding PostgreSQL support #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for PostgreSQL as a database for selfoss. Tested with pg 9.0, but anything reasonably modern (8.x+) should work. Testing platform is debian stable on i386 with pg 9.0.7 and php 5.3.3-7. Squashed commit of the following: commit d65487baf61b60112772e4778f2f4f23082ad5a0 Author: Michael Jackson <[email protected]> Date: Thu Mar 14 22:11:38 2013 -0400 Fixing another boolean/integer mismatch with pg commit f325dfdb1fc02a3bf0e43d27dba52f0077a1018e Author: Michael Jackson <[email protected]> Date: Thu Mar 14 22:05:46 2013 -0400 Further fixes for pg support commit 041050cc99188671889a599b86677980b1e45d1a Author: Michael Jackson <[email protected]> Date: Thu Mar 14 21:50:28 2013 -0400 Initial revision of support for postgresql database.
|
Very cool, postgreSQL support is a very good new feature. |
|
Hi @volkadav. Previously, it was not clear if selfoss was licensed under GPL 3 only, or also any later version. Could you clarify whether you are fine with licensing your contributions under Thanks again and sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thank you for making selfoss! I noticed that the project doesn't presently support postgresql as a database, so I hacked up a patch to add that. The versions I tested with were pg 9.0.7 and php 5.3.3-7 on debian stable i386; operationally I tested by importing my Google Reader OPML file and clicking around some. The config.ini parameters are all the same, db_type would be set to pgsql (and port, likely, to 5432). Probably any postgresql version 8.x or above would work (I checked the things I added against the 8.4 manual as I believe that is the version debian stable ships by default).
I'm guessing that anyone who wants to use this would know the relevant DBA tasks for creating a database and role, setting up authentication, etc. There's a brief note in the header of the Database class pointing people at the online manual.