client: Use prettier for formatting #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for selfoss canceled.
|
I do not like the formatting very much but at least it is consistent and supports TypeScript. https://typescript-eslint.io/troubleshooting/formatting/ Also replace `lint:js` npm script in the `client/` directory with `check:js:lint` and add `check:js` which runs that in addition to newly introduced `check:js:prettify`. This matches how the stylesheet scripts are structured. Adding `eslint-config-prettier` disables stylistic rules that would fight with Prettier. Additionally, I had to remove some clashing from our ESLint config. We are using `eslint-config-prettier` instead of `eslint-plugin-prettier`, the latter would run prettier as part of ESLint but we are already running it separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not like the formatting very much but at least it is consistent and supports TypeScript. https://typescript-eslint.io/troubleshooting/formatting/
Also replace
lint:jsnpm script in theclient/directory withcheck:js:lintand addcheck:jswhich runs that in addition to newly introducedcheck:js:prettify. This matches how the stylesheet scripts are structured.Adding
eslint-config-prettierdisables stylistic rules that would fight with Prettier. Additionally, I had to remove some clashing from our ESLint config.We are using
eslint-config-prettierinstead ofeslint-plugin-prettier, the latter would run prettier as part of ESLint but we are already running it separately.Cherry-picked from #1457