Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HtmlString to distinguish between HTML and plain text strings #1368

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Oct 9, 2022

The database also contains other escaped values:

Similarly the view layer:

So I decided to first systematize the data model by using explicit object for HTML string.

Now we just need to remove the escaping everywhere else (will be a BC break).

@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for selfoss canceled.

Name Link
🔨 Latest commit b44d62f
🔍 Latest deploy log https://app.netlify.com/sites/selfoss/deploys/63ed478dd972010008392181

@jtojnar jtojnar added this to the 2.20 milestone Oct 9, 2022
@jtojnar jtojnar force-pushed the escaping branch 4 times, most recently from 29e14da to 9042236 Compare February 15, 2023 02:30
Also fix bunch of over and under escaping and document the string semantics in API.
@jtojnar jtojnar marked this pull request as ready for review February 15, 2023 21:02
@jtojnar jtojnar merged commit b44d62f into master Feb 15, 2023
@jtojnar jtojnar deleted the escaping branch February 15, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant