Use HtmlString to distinguish between HTML and plain text strings #1368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database also contains other escaped values:
selfoss/src/helpers/ViewHelper.php
Line 144 in ac61872
selfoss/src/controllers/Sources/Write.php
Line 78 in 0920dcb
selfoss/src/controllers/Sources/Write.php
Line 82 in 0920dcb
Similarly the view layer:
selfoss/src/helpers/ViewHelper.php
Line 144 in ac61872
So I decided to first systematize the data model by using explicit object for HTML string.
Now we just need to remove the escaping everywhere else (will be a BC break).