Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Improve screen reader navigability of sources #1345

Merged
merged 8 commits into from
Jul 13, 2022
Merged

Commits on Jul 12, 2022

  1. client: Improve screen reader navigability of sources

    - Turn sources into a list items rather than forms, only the inside is an actual form.
    - Turn the source titles into headings.
    - Mark the edit button as collapsed.
    - Add a placeholder when no sources are present.
    jtojnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    67b0fbf View commit details
    Browse the repository at this point in the history
  2. client: Do not show empty source-params

    This would just potentially clutter the accessibility tree.
    
    Also do not show any other content when loading.
    jtojnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    87e082e View commit details
    Browse the repository at this point in the history
  3. client: Do not make spinner size required

    It should fall back to font size.
    jtojnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    248d9e1 View commit details
    Browse the repository at this point in the history
  4. client: Move deletion spinner outside the menu

    This should have been done in 0432fed
    jtojnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    cb10efc View commit details
    Browse the repository at this point in the history
  5. client: Add textual description to spinners

    For screen readers.
    jtojnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    2d007fe View commit details
    Browse the repository at this point in the history
  6. client: Fix deletion of source form

    This was missed in 0432fed
    
    The menu element is removed from DOM by the time the deletion handler
    run so jQuery’s `parents()` function will not be able to locate the form.
    
    Let’s store an explicit reference to the form and pass it to the event handler.
    jtojnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f1e8fa4 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Configuration menu
    Copy the full SHA
    3fc57ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54a0bca View commit details
    Browse the repository at this point in the history