Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spouts\twitter: Add search #1213

Merged
merged 2 commits into from
Aug 5, 2020
Merged

spouts\twitter: Add search #1213

merged 2 commits into from
Aug 5, 2020

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 4, 2020

This will allow following hashtags.

See the Twitter docs for info about query:

https://developer.twitter.com/en/docs/tweets/search/guides/standard-operators

Closes: #1211


WIP since:

  • It only fetches the latest page, which might not be enough when there are many tweets in a short span of time. We would need to handle pagination.
  • NEWS entry and docs need to be updated.
  • I do not really like adding more core spouts but am not sure how to fix this.

During the DI rewrite, we forgot to call parent constructor.
This will allow following hashtags.

See the Twitter docs for info about query:

https://developer.twitter.com/en/docs/tweets/search/guides/standard-operators

At the moment we only show the latest page so some tweets that would match for more busy search terms might be missed.
@jtojnar jtojnar marked this pull request as ready for review August 5, 2020 14:43
@jtojnar jtojnar merged commit 07077ff into master Aug 5, 2020
@jtojnar jtojnar deleted the twitter-search branch August 5, 2020 15:15
@jtojnar jtojnar added this to the 2.19 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter follow hashtag ?
1 participant