Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various a11y fixes #1133

Merged
merged 8 commits into from
Sep 23, 2019
Merged

Various a11y fixes #1133

merged 8 commits into from
Sep 23, 2019

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Sep 16, 2019

Closes: #1127, #1132, #1028

@jtojnar
a11y: Label search field
dd468f4
@jtojnar
a11y: Hide favicons with ARIA
868ad75
@jtojnar
templates: do not use <div>s inside <li>s
d3b55d4
@jtojnar
a11y: Make settings button on mobile accessible
88a556b
@jtojnar
a11y: do not hide outline
56b3211 
This makes selfoss much more navigable using keyboard.

In the future we can disable it in :focus and only apply it in :focus-visible.
@jtojnar
a11y: make info message button a real button
00ac16d
@jtojnar
a11y: make stream more true buttons
cd1bd75
@jtojnar
Control visibility of item content by aria-expanded
0091b26 
It slightly simplifies the code, allows styling expanded items and serves as a step forward in our accessibility.
@jtojnar jtojnar added this to the 2.19 milestone Sep 16, 2019
@jtojnar jtojnar requested a review from niol September 16, 2019 19:39
@jtojnar
Copy link
Member Author

jtojnar commented Sep 16, 2019

@niol could you please check, especially the last commit?

This was referenced Sep 16, 2019
Open
Closed
Open
@akash07k
Copy link
Contributor

Thanks @jtojnar For this.
Please check my other comments on previous issues.
If possible, can we implement pagination for the best user experience and use aria-current on the current page?
This link represents very nice explanations and examples to this:
https://www.a11ymatters.com/pattern/pagination/

@jtojnar jtojnar merged commit 0091b26 into master Sep 23, 2019
@jtojnar jtojnar deleted the a11y-fixes branch September 23, 2019 08:34
@akash07k akash07k mentioned this pull request Sep 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niol niol niol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19
Development

Successfully merging this pull request may close these issues.

Horizontal scrolling instead of single column view
3 participants
@jtojnar @akash07k @niol