Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add native sharer #1035

Merged
merged 5 commits into from
Oct 16, 2019
Merged

client: add native sharer #1035

merged 5 commits into from
Oct 16, 2019

Commits on Oct 16, 2019

  1. client: add native sharer 

    using Web Share API for browsers that support it

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share

Note that this is still experimental and it will also only work in secure contexts (HTTPS).

Closes: #719
    @jtojnar
    jtojnar committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    8147459 View commit details
    Browse the repository at this point in the history

  2. client: Modernize sharers 

    Use ES6 syntax

selfoss.shares.register now has the following signature:

    (name: String
    , id: String
    , fontawesomeIconClass: String
    , ({url: String, title: String} -> Void
    ) -> bool
    @jtojnar
    jtojnar committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    09b417f View commit details
    Browse the repository at this point in the history

  3. client: Fix shared title 

    During the accessibility improvements we changed the structure of entry title but forgot to update the sharers to reflect the changes.
    @jtojnar
    jtojnar committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    5fb0d0c View commit details
    Browse the repository at this point in the history

  4. client: Improve sharer labels 

    Instead of just “facebook” or “pocket”, use “Share on Facebook” and “Save to Pocket” as the labels and tooltips of the sharing buttons. This will make it slightly clearer.

This again changes the signature of selfoss.shares.register:

    (name: String
    , id: String
    , label: String
    , fontawesomeIconClass: String
    , ({url: String, title: String} -> Void
    ) -> bool
    @jtojnar
    jtojnar committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    933ed88 View commit details
    Browse the repository at this point in the history

  5. client: allow arbitrary icons for sharers 

    so that users can register their own with emoji icons.

Also update NEWS.
    @jtojnar
    jtojnar committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    ea83300 View commit details
    Browse the repository at this point in the history