Reddit spout fixes #1033
Merged
Reddit spout fixes #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, provided URL was appended to a string 'https://www.reddit.com/' textually, resulting in a broken URL when an absolute URL was used. This commit uses GuzzleHttp\Url to construct the URL correctly.
jtojnar
force-pushed
the
reddit-request-fixes
branch
3 times, most recently
from
bf48360
to
26452e1
Compare
|
Fixed #1032 for me. |
Previously, .json extension was just appended to a URL which failed when a query string was used (for example for search). This commit changes the URL construnction so that only the path segment is modified.
Reddit escapes the HTML in selftext_html attribute so we need to unescape it. https://github.com/reddit-archive/reddit/wiki/JSON
The Reddit spout tried to detect if an item points to imgur.com and change the link directly to an image in that case. Unfortunately, it was flaky, for example, gifv files resulted in 403 error. Instead we are using the previews feature, which, as a bonus, also works on sites other than imgur.
jtojnar
force-pushed
the
reddit-request-fixes
branch
from
26452e1
to
6ade1c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow wider range of URLs in Reddit spout, including absolute URLs and searches.