tinystdio: ungetc decrements file position indicator correctly #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the ISO/IEC_9899_1999, section: J.5.16 it is mentioned that there is a file position indicator that is decremented by each call of the ungetc function. The value of the file position indicator was not directed to the right position, this issue is now handled in the ftell function so the file indicator is placed correctly after the function ungetc is called. An "if" condition is added which checks on the value of unget and if it is not equal zero then ungetc function is called so the indicator will be decremented. Signed-off-by: Hana Ashour <[email protected]>
HanaMAshour
force-pushed
the
hanaa_fix_ungetc_position_indicator
branch
from
a6b446f
to
89eb6c3
Compare
This allows fetching the unget value using stdatomic interfaces to ensure atomicity wrt other unget operations. Signed-off-by: Keith Packard <[email protected]>
A pending unget value means that the underlying reported seek position will be off by one. Signed-off-by: Keith Packard <[email protected]>
Make sure ungetc affects ftell value correctly. Signed-off-by: Keith Packard <[email protected]>
pulled the changes from PR picolibc#719 and changed the copyrights in the test Signed-off-by: Hana Ashour <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the ISO/IEC_9899_1999, section: J.5.16 it is mentioned that there is a file position indicator that is decremented by each call of the ungetc function.
The value of the file position indicator was not directed to the right position, this issue is now handled in the ftell function so the file indicator is placed correctly after the function ungetc is called.
An "if" condition is added which checks on the value of unget and if it is not equal zero then ungetc function is called so the indicator will be decremented.