sort_index
: use of only int_index
iterators inside sort_index
#848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplifiy the implementation of
sort_index
, without modifying the API. So,sort_index
still accept an arrayindex
of kindint_index
orint_index_low
, but all iterations and counts are internally done usingint_index
integers.This is a first step to extend
sort_index
to a procedure that accepts an arrayindex
of a intrinsic typeinteger
,real
,complex
, ....Note: these changes partly revert some changes done in #829 and can be compared against #824 (see here for a comparison with the original implementation)
Note2: these changes are in agreement with the implementation in
ord_sort
.cc: @perazz @jalvesz