-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fpm deployment enhancement #802
Conversation
@perazz maybe you know if there is a way to avoid launching the tests |
Yes I fear that would be the only option, though it's clearly sub-optimal (for each new test, it will have to be added to |
I was wondering the same thing! |
These tests were introduced for testing the procedure |
Thanks @jvdp1, removing those tests enables indeed testing from the root build using fpm! I'll propose a modification to the README.md before moving from draft to ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @jalvesz . I just have a few last comments.
A nice improvement is the support of the cpp directives in the branch stdlib-fpm
.
Co-authored-by: Jeremie Vandenplas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played a bit with the script, and I think it adds nice features (especially that cpp
directives are still kept in stdlib-fpm
).
Thank you @jalvesz!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me in its current form.
Down the road, I think we may want this script to be able to pass whatever defined preprocessor macros to the fpm.toml
:
[preprocess]
[preprocess.cpp]
macros = ["added","by","deployment","script"]
So, let's keep that in mind for now.
Totally! While in the current PR I intentionally striped out that function to make things concise, in the script I posted in #791 that function is still available and can be easily added. |
#791 #790 #787
Enable building stdlib with fpm directly from the root folder
Deploy the
stdlib-fpm
from the preprocessing created in the root folder. This deployment could be rendered unnecessary by building directly stdlib from the root.