Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced btest() by popcnt() in bit_count_large() #756

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Replaced btest() by popcnt() in bit_count_large() #756

merged 2 commits into from
Jan 9, 2024

Conversation

PierUgit
Copy link
Contributor

@PierUgit PierUgit commented Jan 3, 2024

Related to issue #724

Test case also added

jvdp1
jvdp1 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. I only have a minor suggestion (which might be overkill).

src/stdlib_bitsets_large.fypp Outdated Show resolved Hide resolved
@jvdp1 jvdp1 requested a review from a team January 3, 2024 22:04
jvdp1
jvdp1 approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wil wait a couple of days, and merge it if there are no other comments.

@jvdp1 jvdp1 requested a review from a team January 7, 2024 14:35
@jvdp1
Copy link
Member

jvdp1 commented Jan 9, 2024

Thank you @PierUgit . As it is a minor chane, I will merge it.

@jvdp1 jvdp1 merged commit 7be6485 into fortran-lang:master Jan 9, 2024
17 checks passed
@PierUgit PierUgit deleted the popcnt2 branch January 15, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierUgit @jvdp1