Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation errors with makefiles due to command-line variable assignments #591

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Fix compilation errors with makefiles due to command-line variable assignments #591

merged 2 commits into from
Dec 8, 2021

Conversation

fiolj
Copy link
Contributor

@fiolj fiolj commented Dec 7, 2021 •
edited by awvwgk
Loading

Closes #589

@awvwgk awvwgk added the build: make Issue with stdlib's manual makefile build label Dec 7, 2021
awvwgk
awvwgk approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@jvdp1
Copy link
Member

jvdp1 commented Dec 7, 2021

Thank you @fiolj . I think that the CI in .github for testing the Makefiles should be modified too. Could you have a look please?

jvdp1
jvdp1 approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @fiolj . I'll merge it.

@jvdp1 jvdp1 merged commit 100f760 into fortran-lang:master Dec 8, 2021
@fiolj fiolj deleted the correct-makefile branch December 8, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

Assignees
No one assigned
Labels
build: make Issue with stdlib's manual makefile build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problem with gnu Make in Makefile.manual
3 participants
@fiolj @jvdp1 @awvwgk