-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib_selection: correction of typos and addition of some checks #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The error message now doesn't mention the condition that k be in the interval [l, r]. Maybe breaking into two if blocks would make it easier on the eye. But I don't have strong feelings about this. |
I just noticed another minor issue in At the moment you can see we are missing a newline in the html view, just under the "Overview of the module" section. Interestingly this formatting issue doesn't occur with the github markdown view. If you can add a newline as part of this pull request, great. Otherwise I can make a pull request later. |
Thank you @ivan-pi . I modified the lines as follows:
|
Done. Thank you @gareth-nx |
@jvdp1 In case you make further changes here, could you please also add a suitable ford comment at the top of the stdlib_selection.fypp, such as:
This statement will then appear on the stdlib module html page: https://stdlib.fortran-lang.org/lists/modules.html Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Mainly fixing typos and links for FORD. Thank you to the reviewers. |
stdlib_selection.md
k
inselect(x, k, kth, letft, right)
is within the interval[left: right]
.ping @gareth-nx