-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meshgrid #18
Comments
Hi, If yes, should we aim for the level of genericity attained by NumPy, or is the Matlab version sufficient? |
If we seek to have only 2d and 3d versions, we could implement them separately under a generic interface:
where the 2d implementation for instance would be a pure subroutine with the following interface
The optional argument Of course there would also the possibility to implement What do you think? |
Hi @Ivanou34 , welcome and thank you for proposing to contribute to This issue is still relevant, and I think it is a good one to get familiar with
Yes, it would be nice to reach the same level of genericity as NumPy. But as a first step I would suggest to first focus on 2d and 3d. See also e.g., Your propposed API of the subroutine in your comment sounds good to me. A wrapper (e.g. function, derived type) could be added in the future, if needed. |
Thanks for your answer @jvdp1 Should I start working on it, or is it preferable to wait for feedback from other people? |
I guess you can start working on this and open a PR. Duscussion about API
and implemtation can tehn continue on real material.
Le dim. 14 janv. 2024, 11:02, Ivanou34 ***@***.***> a écrit :
… Thanks for your answer @jvdp1 <https://github.com/jvdp1>
Should I start working on it, or is it preferable to wait for feedback
from other people?
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5RO7GJVMEYWKQ7RFQGKGDYOOULVAVCNFSM4J5KMSWKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBZGA4TANBYHEYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Here is a 2D implementation https://github.com/certik/fortran-utils/blob/b43bd24cd421509a5bc6d3b9c3eeae8ce856ed88/src/mesh.f90#L164, but NumPy's meshgrid is much more general. Here is Matlab's meshgrid.
The text was updated successfully, but these errors were encountered: