Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use clang in lieu of gcc as C compiler for homebrew-openmpi action #944

Merged
merged 5 commits into from
Jun 19, 2023
Merged

use clang in lieu of gcc as C compiler for homebrew-openmpi action #944

merged 5 commits into from
Jun 19, 2023

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Jun 18, 2023 •
edited
Loading

henilp105
henilp105 approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perazz , looks good to me.

@perazz
Copy link
Contributor Author

perazz commented Jun 18, 2023 •
edited
Loading

Will see after merging if this remains valid, but the issue appears solved by replacing all boolean HOMEBREW_* environemnt variables from "ON" with 1.

awvwgk
awvwgk approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@perazz
Copy link
Contributor Author

perazz commented Jun 19, 2023

Thank you @awvwgk @henilp105, merging this. Will keep an eye on this one.

@perazz perazz merged commit 210aafc into fortran-lang:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henilp105 henilp105 henilp105 approved these changes

@awvwgk awvwgk awvwgk approved these changes

@arteevraina arteevraina Awaiting requested review from arteevraina

@minhqdao minhqdao Awaiting requested review from minhqdao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing CI: (macOS) Install homebrew OpenMPI
3 participants
@perazz @awvwgk @henilp105