Install script: fix query latest release from GitHub on missing curl #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated install.sh script queries the latest fpm release version from github directly, instead of having its version hardcoded
Closed
|
@fortran-lang/admins please assign any reviewers if you wish to close this PR, thanks. |
awvwgk
reviewed
Feb 15, 2023
install.sh
Outdated
Comment on lines
25
to
35
| if command -v curl > /dev/null 2>&1; then | ||
| curl --silent "https://api.github.com/repos/$1/releases/latest" | # Get latest release from GitHub api | ||
| grep '"tag_name":' | # Get tag line | ||
| sed -E 's/.*"([^"]+)".*/\1/' | # Pluck JSON value | ||
| sed -E 's/^v//' # Remove heading "v" if present | ||
| elif command -v wget > /dev/null 2>&1; then | ||
| wget -q -O- "https://api.github.com/repos/$1/releases/latest" | # Get latest release from GitHub api | ||
| grep '"tag_name":' | # Get tag line | ||
| sed -E 's/.*"([^"]+)".*/\1/' | # Pluck JSON value | ||
| sed -E 's/^v//' # Remove heading "v" if present | ||
| else |
There was a problem hiding this comment.
You can reuse the logic later in the script where we define the FETCH variable.
There was a problem hiding this comment.
Looks better now - made it a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the command to query the latest release version from Github by trying curl then wget; with fallback to the last known version release if none of the two commands is available