fpm_environment: lower windows check precedence in get_os_type function #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Could any maintainer please approve the workflows and review the PR whenever they have time? |
awvwgk
approved these changes
Dec 12, 2022
everythingfunctional
approved these changes
Dec 12, 2022
|
Thank you! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have lowered the precedence of the windows check so that this problem does not occur in
cygwin.Known issues:
MINGWstill poses an issue as mentioned in OS detection is faulty #242 (comment)I am not sure how to fix the issue for
MINGW. If someone can guide me, I will be happy to fix it.