-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: macros don't propage to C executables #779
Conversation
57c5747
to
d710c0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing @gnikit , LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gnikit, code changes look good to me 👍 Few minor points about the example package:
- Do we need the
stub.c
file for this example?- If not, can we move the header file into an
include
subdirectory and simplify the manifest?
- If not, can we move the header file into an
- Are you able to update
example_packages/README.md
with the new example packages and why they're needed?
I will have a look at this today. BTW we might have a bug in our hands. Unfortunately, I don't have a OS X machine handy anymore so I can't really dig around.
Sure thing. |
@LKedward test restructured and example_packages/README.md updated. I sorted the example names and added descriptions for a couple more projects that were missing from the table. Descriptions added ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks! All looks good to me 👍
Fixes #777