Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect user provided main-files #646

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jan 9, 2022

Fixes #643

@awvwgk awvwgk requested a review from LKedward January 9, 2022 18:38
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awvwgk, looks good to me! Might be worth adding a c main test case to examples_packages for future testing? Perhaps also worth updating the wording of Executable Targets to show that c executables can be specified (not detected automatically).

@awvwgk
Copy link
Member Author

awvwgk commented Jan 9, 2022

Perhaps also worth updating the wording of Executable Targets to show that c executables can be specified (not detected automatically).

This can be done at the fpm-docs repo, since the manifest-reference here should be deprecated soon (#636).

@awvwgk awvwgk merged commit 64ce7b9 into fortran-lang:main Jan 10, 2022
@awvwgk awvwgk deleted the user-main branch January 10, 2022 07:13
@awvwgk awvwgk added this to the v0.6.0 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot link C main
2 participants