Fix nested pre-processor blocks #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertziegenhagel
force-pushed
the
pp-nested-if
branch
from
e37e69f
to
7c24d0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 88.23% 88.24%
=======================================
Files 35 35
Lines 4795 4796 +1
=======================================
+ Hits 4231 4232 +1
Misses 564 564 ☔ View full report in Codecov by Sentry. |
gnikit
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the pre-processor code, when we check whether a
#defineor#includestatement should be evaluated, only the top of the pre-processor stack was taken into account. This commit changes it so that all the previously taken branches need to evaluate totrue.Fixes #404.