Fix passing incl_suffixes as command line arguments to fortls
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing `--incl_suffix` to fortls did not take any effect. Although the arguments were parsed correctly and set as attributes to the `LangServer` instance, they where never passed to `src_file_exts` and hence got ignored when iterating the root directory.
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 86.96% 86.96%
=======================================
Files 12 12
Lines 4571 4571
=======================================
Hits 3975 3975
Misses 596 596
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
--incl_suffixto fortls as command line arguments did not take any effect. Although the arguments were parsed correctly and set as attributes to theLangServerinstance, they where never passed tosrc_file_extsand hence got ignored later when iterating the root directory.This is especially problematic when fortls is used via the Modern Fortran VS code extension when it tries to pass along settings from the
settings.jsonfile.