Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temp switch to lfortran for donations #242

Merged
merged 1 commit into from
Nov 24, 2022
Merged

chore: temp switch to lfortran for donations #242

merged 1 commit into from
Nov 24, 2022

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Nov 23, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #242 (4837295) into master (4012ea6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          12       12           
  Lines        4475     4475           
=======================================
  Hits         3878     3878           
  Misses        597      597           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry, let's not do this, please. If there is an argument for not linking to an individual developer for optics reasons alone, then pointing it to LFortran doesn't solve the problem, it's actually less relevant (people may wonder why donate to LFortran if they want to support fortls).

Please, if this is an issue with anybody, let's remove the sponsoring link altogether until Fortran-lang has its own account set up via NumFOCUS. Then the optics will be fine.

Disable funding links until NumFOCUS
gets back to us.
@gnikit
Copy link
Member Author

gnikit commented Nov 23, 2022

Every funding link is now disabled, we just have to revert this commit when NumFOCUS gets back to us and update the links.
The only reference to Funding is in the Contributing page and it renders as follows

image

with the link pointing to https://github.com/orgs/fortran-lang/teams/admins/members

Copy link
Member

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me.

@gnikit gnikit merged commit 2427516 into master Nov 24, 2022
@gnikit gnikit deleted the docs/funding branch November 24, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants