Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider setuptools_scm #326

Closed
fosskers opened this issue Oct 11, 2023 · 2 comments · Fixed by #330
Closed

Consider setuptools_scm #326

fosskers opened this issue Oct 11, 2023 · 2 comments · Fixed by #330
Labels
dependencies Pull requests that update a dependency file

Comments

@fosskers
Copy link

fosskers commented Oct 11, 2023 •
edited
Loading

Describe the bug

https://pypi.org/project/setuptools-scm-git-archive/, as introduced in #44, is unfortunately deprecated. It is suggested that setuptools_scm is used instead.

This was brought to my attention by a downstream user, so I'm passing the suggestion along.

Thank you for your time.
@fosskers fosskers added the bug Something isn't working label Oct 11, 2023
gnikit added a commit that referenced this issue Oct 11, 2023
@gnikit
maint: remove obsolete setuptools_scm_git_archive
3b11c18 
Fixes #326
@gnikit gnikit mentioned this issue Oct 11, 2023
Closed
@gnikit gnikit added dependencies Pull requests that update a dependency file and removed bug Something isn't working labels Oct 11, 2023
@gnikit
Copy link
Member

gnikit commented Oct 11, 2023

We don't use .git_archival.txt other than removing the dependency and using and pinning the lower version is there something else that needs to be done?

@gnikit gnikit mentioned this issue Oct 11, 2023
Merged
@fosskers
Copy link
Author

According to https://github.com/Changaco/setuptools_scm_git_archive#migration-guide that should be sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
2 participants
@fosskers @gnikit