bug: Error hovering an associated function

[minhqdao]

When I use the Modern Fortran plugin in VSCode and hover hi in this little piece of code:

program main
  implicit none

  associate (hi => say_hi())
    if (hi) print *, 'Bye'
  end associate

contains

  logical function say_hi()
    print *, 'Hi'
    say_hi = .true.
  end

end program

I get this error message:

The program, however, runs normally and prints:

Hi
Bye

Specs

• macOS Ventura 13.2.1, M1
• Visual Studio Code 1.76.2
• Modern Fortran v3.2.0, but the same is observed on the pre-release version v3.4.2023030801
• fortls 2.13.0, installed via Homebrew
• Python 3.11.2

Related Issues: #214, #108

[Carltoffel]

I have a possibly related bug: A function can be elemental (or not) but as soon as it is also logical or any other type, I will no longer get the docstring in the tooltip.

Minimal example:

program main
    ! type a or be here:

contains

function a()
    !! this shoes up
    logical a
    a = .true.
end function

logical function b()
    !! this doesn't
    b = .false.
end function

end program main

v2.13.0 in neovim v0.9.0

[gnikit]

I completely missed this @minhqdao, will have a look

[gnikit]

Traceback:

Traceback (most recent call last):
  File "/home/gn/Code/Python/fortls/venv/bin/fortls", line 8, in <module>
    sys.exit(main())
  File "/home/gn/Code/Python/fortls/fortls/__init__.py", line 45, in main
    debug_server_general(args, vars(args))
  File "/home/gn/Code/Python/fortls/fortls/__init__.py", line 290, in debug_server_general
    hover_results = s.serve_hover(
  File "/home/gn/Code/Python/fortls/fortls/langserver.py", line 1111, in serve_hover
    var_obj.get_hover_md(long=True).replace(
  File "/home/gn/Code/Python/fortls/fortls/objects.py", line 1810, in get_hover_md
    return fortran_md(*self.get_hover(long, drop_arg))
  File "/home/gn/Code/Python/fortls/fortls/objects.py", line 1801, in get_hover
    hover_str = ", ".join([self.get_desc()] + self.get_keywords())
  File "/home/gn/Code/Python/fortls/fortls/objects.py", line 1817, in get_keywords
    return get_keywords(self.link_obj.keywords, self.link_obj.keyword_info)
AttributeError: 'Function' object has no attribute 'keyword_info'

[Carltoffel]

I completely missed this @minhqdao, will have a look

Was the bug I mentioned related, or should I open a new bug report? :)

[gnikit]

Hey @Carltoffel so there is a difference in the hover signatures, but you can always see the documentation.

[Carltoffel]

Ah, thanks. Then it probably is a problem with the LSP implementation in neovim.

[gnikit]

The inconsistency between the 2 docstrings is tracked in #281.

[gnikit]

I will try and issue a pre-release for v3.0.0 for people to be able to download from PyPi (although the pre-release version will still have a lower precedence over the stable releases, so it won't be installed automatically).

In the meantime you can try the latest fortls version which includes a bunch of bug fixes, performance improvements and a new Markdown docstring parser via:

pip install git+https://github.com/fortran-lang/fortls.git

[Carltoffel]

Thank you!
I'm not sure if I installed the correct version (2.13.1.dev156+g6a82432) but it looks better now:

However, the format is still messed up.

[gnikit]

So the new hover results, take the docstrings and assemble them in markdown. Then the client (VSCode, neovim, Emacs, etc. ) Is meant to render that markdown. Not sure why neovim is lagging behind on that https://www.reddit.com/r/neovim/comments/tx40m2/is_it_possible_to_improve_lsp_hover_look/

Currently there is no way to use the old style docs (it was to expensive to maintain both types of docs assembly processes).