like for test target, instead of hardcoding make dependencies, check for make coverage
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for make coverage, will allow to cover build tags in fortio/log
asha-oss
approved these changes
Jun 30, 2024
ccoVeille
reviewed
Jun 30, 2024
|
used in fortio/log#63 |
ldemailly
added a commit
to fortio/log
that referenced
this pull request
Jul 1, 2024
…json (#63) * no_http/no_net and no_json buildtags * adding info about no_json and github.com/Zxilly/go-size-analyzer/cmd/gsa * update comments and add test for nil *string * adding make coverage now that fortio/workflows#51 is done * added tests for struct etc * lint the no_json path too * json->JSON Co-authored-by: ccoVeille <[email protected]> * verify through test that byte = uint8 works and added log.Rune(k,v) to print 1 character as one would most likely expect * put variable in makefile for go so I can run 'make GO_BIN=go1.23rc1' --------- Co-authored-by: ccoVeille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will allow to cover build tags in fortio/log