Moved ready to a dflag so it can be changed with curl on 7999 or in cmap

Makefile

@@ -34,4 +34,4 @@ tail-log:
 	kubectl logs -f -n memstore memstore-0 | logc
 
 debug-pod:
-	kubectl run debug --image=ubuntu --restart=Never -- /bin/sleep infinity
+	kubectl run debug --image=ubuntu -- /bin/sleep infinity

chart/templates/02_config.yaml

@@ -9,3 +9,5 @@ data:
   dns: memstore-internal.memstore.svc.cluster.local
   dns-interval: 5s
   statefulset: "true"
+  ready: "false"
+  config-port: "7999"

mstore/dnsWatch.go

@@ -53,7 +53,7 @@ func reverseDNS(ips sets.Set[string]) (sets.Set[string], bool) {
 		allNames.Add(shortName)
 	}
 	if !allNames.Has(myName) {
-		log.Errf("My name %q not found in the reverse DNS list: %v", myName, allNames)
+		log.Warnf("My name %q not found in the reverse DNS list: %v", myName, allNames)
 	}
 	return allNames, hasError
 }
@@ -76,7 +76,7 @@ func checkDNS(serviceName string) {
 		var hasErrors bool
 		peerNames, hasErrors = reverseDNS(newIPs)
 		numPeers = len(peerNames)
-		log.Infof("StatefulSet mode, errs %v found %d peers (including ourselves %q) for %q: %v",
+		log.Infof("StatefulSet mode, errs %v found %d peers (possibly including ourselves %q) for %q: %v",
 			hasErrors, numPeers, myName, serviceName, peerNames)
 		if hasErrors {
 			return

probes/probes.go

@@ -5,35 +5,39 @@ import (
 	"net/http"
 	"sync"
 
+	"fortio.org/dflag"
 	"fortio.org/log"
 )
 
 type state struct {
 	started bool
 	live    bool
-	ready   bool
 	// mutex
 	mutex sync.Mutex
 }
 
-var State = state{}
+var (
+	State     = state{}
+	ReadyFlag = dflag.NewBool(false, "Initial readiness state")
+)
 
 func (s *state) SetLive(live bool) {
 	s.mutex.Lock()
 	s.live = live
 	s.mutex.Unlock()
+	log.Infof("Setting live to %v", live)
 }
 
 func (s *state) SetReady(ready bool) {
-	s.mutex.Lock()
-	s.ready = ready
-	s.mutex.Unlock()
+	_ = ReadyFlag.SetV(ready)
+	log.Infof("Setting ready to %v", ready)
 }
 
 func (s *state) SetStarted(started bool) {
 	s.mutex.Lock()
 	s.started = started
 	s.mutex.Unlock()
+	log.Infof("Setting started to %v", started)
 }
 
 func (s *state) IsLive() bool {
@@ -43,9 +47,7 @@ func (s *state) IsLive() bool {
 }
 
 func (s *state) IsReady() bool {
-	s.mutex.Lock()
-	defer s.mutex.Unlock()
-	return s.ready
+	return ReadyFlag.Get()
 }
 
 func (s *state) IsStarted() bool {

proto.go

@@ -22,6 +22,7 @@ func main() {
 	dflag.Flag("dns", mstore.DNSWatch)
 	dflag.Flag("dns-interval", mstore.DNSWatchSleepTime)
 	dflag.FlagBool("statefulset", mstore.StatefulSet)
+	dflag.FlagBool("ready", probes.ReadyFlag)
 	scli.ServerMain()
 	if mstore.StatefulSet.Get() && mstore.DNSWatch.Get() == "" {
 		log.Fatalf("StatefulSet mode needs -dns to be set")
@@ -43,7 +44,7 @@ func main() {
 	probes.Setup(mux)
 	probes.State.SetLive(true)
 	probes.State.SetStarted(true)
-	probes.State.SetReady(true)
+	// For testing/changing we can use curl to set flags podip:7999/set?name=ready&value=true
 	/*
 		time.Sleep(50 * time.Second) // give time for the probes to be ready
 		log.Warnf("Switching back to not ready")