improve readme and doc and comments in test

README.md

@@ -75,6 +75,15 @@ JSON formatted logs can also be converted back to text later/after capture and s
 
 The `log.Colors` can be used by callers and they'll be empty string when not in color mode, and the ansi escape codes otherwise.
 
+# HTTP request/response logging
+
+`LogAndCall()` combines `LogRequest` and `LogResponse` for a light middleware recording what happens during serving of a request (both incoming and outgoing attributes).
+
+For instance (most attributes elided for brievety, also logs client cert and TLSInfo if applicable)
+```json
+{"level":"info","msg":"test-log-and-call2","method":"GET","url":{"Path":"/tea"},"status":418,"size":5,"microsec":100042}
+```
+
 # Config
 
 You can either use `fortio.org/cli` or `fortio.org/scli` (or `dflags`) for configuration using flags (or dynamic flags and config map) or use the environment variables:

http_logging.go

@@ -129,11 +129,14 @@ func (rr *ResponseRecorder) WriteHeader(code int) {
 	rr.StatusCode = code
 }
 
-// LogResponse logs the response code, byte size and duration of the request.
-// additional key:value pairs can be passed as extraAttributes.
+// LogAndCall logs the incoming request and the response code, byte size and duration
+// of the request.
+//
 // If Config.CombineRequestAndResponse or the LOGGER_COMBINE_REQUEST_AND_RESPONSE
 // environment variable is true. then a single log entry is done combining request and
-// response information, including catching for panic
+// response information, including catching for panic.
+//
+// Additional key:value pairs can be passed as extraAttributes.
 //
 //nolint:revive // name is fine.
 func LogAndCall(msg string, hf http.HandlerFunc, extraAttributes ...KeyVal) http.HandlerFunc {

http_logging_test.go

@@ -75,7 +75,7 @@ func TestLogAndCall(t *testing.T) {
 	Config.LogFileAndLine = false
 	Config.JSON = true
 	Config.NoTimestamp = true
-	Config.CombineRequestAndResponse = false // single line test
+	Config.CombineRequestAndResponse = false // Separate request and response logging
 	var b bytes.Buffer
 	w := bufio.NewWriter(&b)
 	SetOutput(w)
@@ -96,7 +96,7 @@ func TestLogAndCall(t *testing.T) {
 	}
 	hr.URL = &url.URL{Path: "/tea"}
 	b.Reset()
-	Config.CombineRequestAndResponse = true // single line test
+	Config.CombineRequestAndResponse = true // Combined logging test
 	LogAndCall("test-log-and-call2", testHandler).ServeHTTP(hw, hr)
 	w.Flush()
 	actual = b.String()