Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: ccoVeille <[email protected]>
  • Loading branch information
ldemailly and ccoVeille authored Jul 18, 2024
1 parent 531e709 commit 867aa5c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions goroutine/gid_tinygo.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ const IsTinyGo = true
var (
counter int64
mapping = make(map[uintptr]int64)
// TinyGo at the moment is single threaded so this is not needed but it's good to have anyway
// in case that changes. It does had ~5ns (from 20ns vs 4ns big go) but it's better to be correct.
// In theory the mutex could be noop on platforms where everything is single threaded.
// TinyGo at the moment is single threaded, so this is not needed, but it's good to have anyway
// in case that changes. It does add ~5ns (from 20ns vs 4ns big go) but it's better to be correct.
// In theory, the mutex could be noop on platforms where everything is single threaded.
lock sync.Mutex
)

Expand Down
2 changes: 1 addition & 1 deletion logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func (l *JSONEntry) Time() time.Time {
//nolint:gochecknoinits // needed
func init() {
if !isValid(os.Stderr) { // wasm in browser case for instance
SetOutput(os.Stdout) // this could also be invalid too but... we tried.
SetOutput(os.Stdout) // this could also be invalid too, but... we tried.
}
setLevel(Info) // starting value
levelToStrM = make(map[string]Level, 2*len(LevelToStrA))
Expand Down

0 comments on commit 867aa5c

Please sign in to comment.