Merge pull request #39 from fortio/shared_workflows

switch to shared workflows + linter fix

.github/workflows/include.yml

@@ -0,0 +1,20 @@
+# Same as full workflow (eg from fortio/multicurl) but without the goreleaser step
+name: "Shared library fortio workflows"
+
+on:
+    push:
+      branches: [ main ]
+    pull_request:
+      branches: [ main ]
+
+jobs:
+    call-gochecks:
+        uses: fortio/workflows/.github/workflows/gochecks.yml@main
+#    call-codecov:
+#        uses: fortio/workflows/.github/workflows/codecov.yml@main
+    call-codeql:
+        uses: fortio/workflows/.github/workflows/codeql-analysis.yml@main
+        permissions:
+            actions: read
+            contents: read
+            security-events: write

.gitignore

@@ -1,3 +1,4 @@
+.golangci.yml
 # Binaries for programs and plugins
 *.exe
 *.exe~

Makefile

@@ -0,0 +1,8 @@
+
+lint: .golangci.yml
+	golangci-lint run
+
+.golangci.yml: Makefile
+	curl -fsS -o .golangci.yml https://raw.githubusercontent.com/fortio/workflows/main/golangci.yml
+
+.PHONY: lint

assert.go

@@ -114,7 +114,7 @@ func Assert(t *testing.T, cond bool, msg string, rest ...interface{}) {
 
 type hasT interface {
 	T() *testing.T
-	SetT(*testing.T)
+	SetT(t *testing.T)
 }
 
 // TestSuite to be used as base struct for test suites.
@@ -162,7 +162,7 @@ func Run(t *testing.T, suite hasT) {
 		}
 		test := testing.InternalTest{
 			Name: method.Name,
-			F: func(t *testing.T) {
+			F: func(_ *testing.T) {
 				method.Func.Call([]reflect.Value{reflect.ValueOf(suite)})
 			},
 		}