Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shiplift crate - virtual_size optional field of docker image a… #7

Closed
wants to merge 1 commit into from

Conversation

aditijannu
Copy link
Collaborator

…ttributes

Issue:
The following converter error was noticed:

[2024-03-13T21:47:27Z WARN  container_converter::docker] Encountered error when searching for local image parent-base. SerdeJsonError(Error("missing field `VirtualSize`", line: 1, column: 2749)).
[2024-03-13T21:47:27Z ERROR container_converter] Converter exited with error: Failed retrieving requisite parent-base image. "Image parent-base not found in local repository."
Error: "Failed retrieving requisite parent-base image. \"Image parent-base not found in local repository.\""

Upon looking into the docker 24.0 release notes, it's seen that virtual_size field is deprecated (https://docs.docker.com/engine/release-notes/24.0/) and may not longer be provided by the docker daemon. To fix the above error, an update in the shiplift crate used by the converter was required - fortanix/shiplift#10

This PR picks up the latest changes from the shiplift crate and ensures virtual_size is used as an optional parameter.

@aditijannu aditijannu closed this Mar 15, 2024
@aditijannu
Copy link
Collaborator Author

Included changes from this PR in aj/SALM-561 branch. Closing this branch.

@aditijannu aditijannu deleted the aj/SALM-563 branch March 15, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants