Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation had several issues:
pcap-async
relied on a blocking function (smol::unblock
) internally making it not reallyasync
buffer_for
Duration, not sure if this was related or not.These are fixed by switching to the
pcap
crate which has since gotten its own async implementation. I also added an async implementation for the other direction.Depends on rust-pcap/pcap#372 and rust-pcap/pcap#373