RTE-54: Memory Allocators Performance Testing #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbyAtFortanix
commented
Jun 5, 2024
BobbyAtFortanix
commented
- create: basic, hot & cold performance test (memory allocation)
- createde basic, hot & cold performance test (memory allocation)
aditijannu
reviewed
Jun 27, 2024
|
|
||
|
|
||
| use std::alloc::AllocError; | ||
| //use std::env; |
| static APP_NAME: &str = "mem-performance-test"; | ||
|
|
||
| // Test Parameters | ||
| // println!(" AllocFree: does alloc buf_size followed by free for n_sec"); |
There was a problem hiding this comment.
Remove call to println functions and only keep textual data as comments.
| // println!(" AllocManyFreeManyWarm: silmilar to AllocManyFreeManyCold but it ignores the "); | ||
| // println!(" first run and run each buf_size without restarting the application."); | ||
|
|
||
| const POW: u32 = 3; // MIN_SIZE specified as power of 2. 8bytes = 2^3 |
There was a problem hiding this comment.
MIN_SIZE_POW seems like a better name for this constant
|
|
||
| let size = buf_size / mem::size_of::<u64>(); | ||
|
|
||
| // #[cfg(never)] |
There was a problem hiding this comment.
clean up unused code here and the rest of this file
|
|
||
| // calculate n_loops per second | ||
| let mut loops_per_sec: u32 = 0; | ||
| for i in 1..100 { |
There was a problem hiding this comment.
100 can be defined as a test constant
| if vec.capacity() < n_els { | ||
| vec.reserve(n_els - vec.capacity()); | ||
| } | ||
| if vec.len() <= 0 { vec.clear(); } // j.i.c. - expected to be empty |
| return "!zero_after_alloc"; | ||
| } | ||
|
|
||
| fn main() { |
There was a problem hiding this comment.
Can you add some of the test results as a file in the examples/mem-perforamnce-test directory so someone who runs the test in the future is aware of expected results?
|
You should target the PR to master branch and not aj/update-sgx-alloc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.