Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make x509::Time more useful #331

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Make x509::Time more useful #331

merged 1 commit into from
Oct 27, 2023

Conversation

s-arash
Copy link
Collaborator

@s-arash s-arash commented Oct 26, 2023

This PR makes the x509::Time type more useful by

  • adding getters for its fields (year, hour, etc.)
  • implementing conversion traits between chrono::NaiveDateTime and x509::Time (gated by the chrono feature)

@s-arash s-arash requested a review from Taowyoo October 26, 2023 21:59
Taowyoo
Taowyoo approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@Taowyoo Taowyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some nitpicks.

mbedtls/src/x509/mod.rs Outdated Show resolved Hide resolved
ci.sh Show resolved Hide resolved
@Taowyoo Taowyoo merged commit 5b54663 into fortanix:main Oct 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taowyoo Taowyoo Taowyoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-arash @Taowyoo