Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bounds on establish, test that Send gets derived as needed #186

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Remove bounds on establish, test that Send gets derived as needed #186

merged 1 commit into from
Feb 12, 2022

Conversation

AdrianCX
Copy link
Contributor

No description provided.

@AdrianCX AdrianCX mentioned this pull request Feb 11, 2022
Closed
jethrogb
jethrogb reviewed Feb 11, 2022
View reviewed changes
Copy link
Member

@jethrogb jethrogb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the Hyper tests to remove 'static where possible

@MabezDev
Copy link

Looks good so far. Can the 'static bound be removed on the following impl?

rust-mbedtls/mbedtls/src/ssl/context.rs

Line 40 in 51ad965

impl<IO: Read + Write + 'static> IoCallback for IO {

@AdrianCX
Copy link
Contributor Author

Please modify the Hyper tests to remove 'static where possible

fixed

@AdrianCX
Copy link
Contributor Author

Looks good so far. Can the 'static bound be removed on the following impl?

rust-mbedtls/mbedtls/src/ssl/context.rs

Line 40 in 51ad965

impl<IO: Read + Write + 'static> IoCallback for IO {

done, thanks

@jethrogb
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Feb 11, 2022
@bors @AdrianCX
Merge #186
020e01d 
186: Remove bounds on establish, test that Send gets derived as needed r=jethrogb a=AdrianCX



Co-authored-by: Adrian Cruceru <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 11, 2022

Build failed:

  • continuous-integration/travis-ci/push

@AdrianCX
Copy link
Contributor Author

bors retry

@bors
Copy link
Contributor

bors bot commented Feb 12, 2022

Build succeeded:

@bors bors bot merged commit 271a056 into master Feb 12, 2022
@Taowyoo Taowyoo deleted the acruceru/send-derivation branch October 20, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jethrogb jethrogb jethrogb left review comments

@raoulstrackx raoulstrackx Awaiting requested review from raoulstrackx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianCX @MabezDev @jethrogb