JSON-RPC Cache improvements (authorization in dispatcher, poll error metric fix) #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dkeysil
commented
Apr 3, 2024
dkeysil
commented
- I'm adding support of JWT authorization on dispatcher in blocksdata client
- Poll error metric should be created as system metric
aomerk
reviewed
Apr 4, 2024
aomerk
approved these changes
Apr 4, 2024
aomerk
reviewed
Sep 5, 2024
| b, err := io.ReadAll(resp.Body) | ||
| req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", scannerJwt)) | ||
|
|
||
| resp, err := httpclient.Default.Get(dispatcherUrl) |
There was a problem hiding this comment.
it should be http.DefaultClient.Do(req)
There was a problem hiding this comment.
(Please note the difference between httpclient.Default and http.DefaultClient - the former is from our core repo and has some defaults.)
There was a problem hiding this comment.
yes, the constructed request is not used and therefore the requests don't have the auth bearer header - client is making a generic GET call to dispatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.