added tests for memcache instance

forseti-security · Apr 1, 2021 · 380e629 · 380e629
1 parent 035e22e
commit 380e629
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/tests/test_resources.py b/tests/test_resources.py
@@ -40,7 +40,8 @@
 from rpe.resources.gcp import GcpComputeFirewall
 from rpe.resources.gcp import GcpComputeSubnetwork
 from rpe.resources.gcp import GcpDataflowJob
-from rpe.resources.gcp import GcpRedisInstance
+from rpe.resources.gcp import GcpMemorystoreRedis
+from rpe.resources.gcp import GcpMemcacheInstance
 
 test_project = "my_project"
 test_resource_name = "my_resource"
@@ -251,10 +252,20 @@
             'location': 'us-central1',
             'project_id': test_project
         },
-        cls=GcpRedisInstance,
+        cls=GcpMemorystoreRedis,
         resource_type='redis.googleapis.com/Instance',
         name='//redis.googleapis.com/projects/my_project/locations/us-central1/instances/my_resource'
     ),
+    ResourceTestCase(
+        resource_data={
+            'name': test_resource_name,
+            'location': 'us-central1',
+            'project_id': test_project
+        },
+        cls=GcpMemcacheInstance,
+        resource_type='memcache.googleapis.com/Instance',
+        name='//memcache.googleapis.com/projects/my_project/locations/us-central1/instances/my_resource'
+    ),
 ]
 
 

diff --git a/tests/test_resources_cai.py b/tests/test_resources_cai.py
@@ -43,7 +43,8 @@
 from rpe.resources.gcp import GcpIamServiceAccount
 from rpe.resources.gcp import GcpIamServiceAccountKey
 from rpe.resources.gcp import GcpDataflowJob
-from rpe.resources.gcp import GcpRedisInstance
+from rpe.resources.gcp import GcpMemorystoreRedis
+from rpe.resources.gcp import GcpMemcacheInstance
 
 client_kwargs = {
     'credentials': Credentials(token='')
@@ -218,7 +219,14 @@
             "name": "//redis.googleapis.com/projects/test-project/locations/us-central1/instances/test-resource",
             "asset_type": "redis.googleapis.com/Instance",
         },
-        resource_cls=GcpRedisInstance
+        resource_cls=GcpMemorystoreRedis
+    ),
+    CaiTestCase(
+        data={
+            "name": "//memcache.googleapis.com/projects/test-project/locations/us-central1/instances/test-resource",
+            "asset_type": "memcache.googleapis.com/Instance",
+        },
+        resource_cls=GcpMemcacheInstance
     ),
 ]