Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RUST_SCRIPT_BASE_PATH reports the wrong path when rust-script executes with --base-path #136

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: RUST_SCRIPT_BASE_PATH reports the wrong path when rust-script executes with --base-path #136

merged 1 commit into from
Sep 3, 2024

Conversation

wmmc88
Copy link
Contributor

@wmmc88 wmmc88 commented Aug 1, 2024

fixes #135

@wmmc88
Copy link
Contributor Author

wmmc88 commented Aug 1, 2024

@fornwall I validated that this fixes the issue reported in #135, but do you have advice for the best place in the repo to insert some sort of test for this scenario?

@fornwall fornwall merged commit 66ea3e4 into fornwall:main Sep 3, 2024
@fornwall
Copy link
Owner

fornwall commented Sep 3, 2024

@wmmc88 Thanks and sorry for the delay here!

This has now been merged and released in version 0.35.0.

do you have advice for the best place in the repo to insert some sort of test for this scenario?

Added a test in da33453, using the test mechanism in tests/scripts/. This has not been ported to run under Windows yet, but is a nice&simple way to run some kind of tests.

@wmmc88 wmmc88 deleted the fix-base-path-with-arg branch September 4, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUST_SCRIPT_BASE_PATH reports the wrong path when rust-script executes with --base-path arg
2 participants
@wmmc88 @fornwall