Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic added inputs not triggers form revalidation #550

Closed
felixmosh opened this issue Aug 27, 2020 · 0 comments · Fixed by #551
Closed

Dynamic added inputs not triggers form revalidation #550

felixmosh opened this issue Aug 27, 2020 · 0 comments · Fixed by #551
Assignees
Labels

Comments

@felixmosh
Copy link
Contributor

felixmosh commented Aug 27, 2020

Due to my refactor of improve initial render (#490 (comment)) there is a bug which not revalidate the form (if the input is not part of the form render path).

I've created an example which demonstrate it https://codesandbox.io/s/formsy-semantic-ui-formselect-options-issue-forked-wq32d?file=/src/Inputs.js

This happens because I've removed the validate from the form's attachToForm method, because the test case was mistakenly tried to submit the form (which triggered re-validation).

@felixmosh felixmosh self-assigned this Aug 27, 2020
@felixmosh felixmosh added the bug label Aug 27, 2020
felixmosh added a commit that referenced this issue Aug 27, 2020
* Revalidate form when dynamic inputs are added, fixes #550

* Improve pr after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant